Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer dependency issues with storybook #4963

Open
sarayourfriend opened this issue Sep 20, 2024 · 0 comments
Open

Peer dependency issues with storybook #4963

sarayourfriend opened this issue Sep 20, 2024 · 0 comments
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend

Comments

@sarayourfriend
Copy link
Contributor

Current Situation

There are many peer dependency issues with Storybook on main. Check this output from CI:

playwright-1  |  WARN  Issues with peer dependencies found
playwright-1  | .
playwright-1  | ├─┬ @nuxtjs/storybook 8.3.0-28771560.b2b9b16
playwright-1  | │ └─┬ @storybook-vue/nuxt 8.3.0-28771560.b2b9b16
playwright-1  | │   └─┬ @nuxt/vite-builder 3.13.2
playwright-1  | │     └─┬ vite-plugin-checker 0.8.0
playwright-1  | │       └── ✕ unmet peer vue-tsc@~2.1.6: found 2.1.4
playwright-1  | └─┬ @storybook-vue/nuxt 8.3.0-28771560.b2b9b16
playwright-1  |   ├─┬ @storybook/builder-vite 8.3.2
playwright-1  |   │ ├── ✕ unmet peer storybook@^8.3.2: found 8.2.9
playwright-1  |   │ └─┬ @storybook/csf-plugin 8.3.2
playwright-1  |   │   └── ✕ unmet peer storybook@^8.3.2: found 8.2.9
playwright-1  |   ├─┬ @storybook/vue3 8.3.2
playwright-1  |   │ ├── ✕ unmet peer storybook@^8.3.2: found 8.2.9
playwright-1  |   │ ├─┬ @storybook/components 8.3.2
playwright-1  |   │ │ └── ✕ unmet peer storybook@^8.3.2: found 8.2.9
playwright-1  |   │ ├─┬ @storybook/manager-api 8.3.2
playwright-1  |   │ │ └── ✕ unmet peer storybook@^8.3.2: found 8.2.9
playwright-1  |   │ ├─┬ @storybook/preview-api 8.3.2
playwright-1  |   │ │ └── ✕ unmet peer storybook@^8.3.2: found 8.2.9
playwright-1  |   │ └─┬ @storybook/theming 8.3.2
playwright-1  |   │   └── ✕ unmet peer storybook@^8.3.2: found 8.2.9
playwright-1  |   └─┬ @storybook/vue3-vite 8.3.2
playwright-1  |     └── ✕ unmet peer storybook@^8.3.2: found 8.2.9
playwright-1  | 

Suggested Improvement

Resolve the peer dependency issues. Refer to the PR that closed #4733 for examples of how to investigate and fix this.

Benefit

Reliable and correct dependency tree.

@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: frontend Related to the Nuxt frontend labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant