Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playwright tests do not fail if the snapshot name is completely new #4927

Open
obulat opened this issue Sep 13, 2024 · 0 comments
Open

Playwright tests do not fail if the snapshot name is completely new #4927

obulat opened this issue Sep 13, 2024 · 0 comments
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend

Comments

@obulat
Copy link
Contributor

obulat commented Sep 13, 2024

Description

If the snapshot does not exist in the repository, and is created during the CI run, the CI passes. This happens because we only check if any existing binary files changed, not if there are any new binary files.

Reproduction

  1. See this run: https://github.com/WordPress/openverse/actions/runs/10851740459/job/30116308306?pr=4914

Additional context
@obulat obulat added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: frontend Related to the Nuxt frontend labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse Backlog
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@obulat