Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Styles JSON data inspector #697

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Global Styles JSON data inspector #697

merged 4 commits into from
Aug 12, 2024

Conversation

matiasbenedetto
Copy link
Contributor

@matiasbenedetto matiasbenedetto commented Aug 8, 2024 •
edited
Loading

What?

Add Global Styles JSON data inspector.

Why?

Closes: #696

Screencast

Demo:

2024-08-08.15-29-53.mp4

@matiasbenedetto matiasbenedetto added the enhancement New feature or request label Aug 8, 2024
@matiasbenedetto matiasbenedetto mentioned this pull request Aug 8, 2024
Closed
@madhusudhand
Copy link
Member

This is a helpful tool to inspect the customization.
Even though its a JSON structure (same as theme.json), we should probably call it something like Global Style Inspector, Global Style Customizations, View Custom Styles ?

@matiasbenedetto
Copy link
Contributor Author

matiasbenedetto commented Aug 12, 2024 •
edited
Loading

👍 I renamed the options to Global Style Customizations: 6f2f0ac (#697)

jffng
jffng approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well, nice addition. Approved pending addressing one issue with the button text.

src/plugin-sidebar.js Outdated Show resolved Hide resolved
@matiasbenedetto
Copy link
Contributor Author

Good, I committed that. I'm merging this. Thanks for the reviews.

@matiasbenedetto matiasbenedetto merged commit 36310c3 into trunk Aug 12, 2024
2 checks passed
@matiasbenedetto matiasbenedetto deleted the add/global-styles-viewr branch August 12, 2024 15:52
@MaggieCabrera MaggieCabrera mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jffng jffng jffng approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add view Global Styles JSON option
3 participants
@matiasbenedetto @madhusudhand @jffng