Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP 8.1 errors caused by missing page titles #462

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Fix PHP 8.1 errors caused by missing page titles #462

merged 2 commits into from
Oct 26, 2023

Conversation

vcanales
Copy link
Member

@vcanales vcanales commented Oct 24, 2023 •
edited
Loading

It achieves the same effect — keeping those submenus from being displayed — while avoiding PHP errors.

Errors shown that need to be fixed:

  • Anywhere on the admin page.
  • On the "Add Google Font" and "Add Local Font" sections.
    Error shown: 
    Deprecated: strip_tags(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/html/wp-admin/admin-header.php on line 36

Closes: #168

Replace null with empty string on add menu page
ef36c11 
Achieves the same effect — keeping those submenus from being displayed —
while avoiding PHP errors.

Closes: #168
@vcanales vcanales added the bug Something isn't working label Oct 24, 2023
@vcanales vcanales marked this pull request as ready for review October 25, 2023 15:41
@vcanales vcanales requested a review from a team October 25, 2023 15:42
@vcanales vcanales changed the title Replace null with empty string on add menu page Fix PHP 8.1 errors caused by missing page titles Oct 25, 2023
mikachan
mikachan approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this 🙇 Changes look good to me!

@vcanales vcanales merged commit c4d1ce7 into trunk Oct 26, 2023
1 check passed
@vcanales vcanales mentioned this pull request Oct 26, 2023
Closed
@vcanales vcanales mentioned this pull request Nov 13, 2023
Closed
@vcanales vcanales deleted the avoid-null-on-submenu-page-call branch May 23, 2024 07:47
@MaggieCabrera MaggieCabrera mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikachan mikachan mikachan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8.1 errors.
2 participants
@vcanales @mikachan