Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value for recommended plugins section #406

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

vcanales
Copy link
Member

@vcanales vcanales commented Jun 26, 2023

Add a default value to $recommended_plugins_section to avoid errors when providing no recommended plugins.

Error:

Warning: Undefined variable $recommended_plugins_section in wp-content/plugins/create-block-theme/admin/create-theme/theme-readme.php on line 47

@vcanales vcanales added the bug Something isn't working label Jun 26, 2023
@vcanales vcanales requested a review from mikachan June 26, 2023 18:08
@pbking
Copy link
Contributor

pbking commented Jun 27, 2023

I can't say that I was able to reproduce the error you mentioned. I tried all the ways I could think of both in the wp-admin interface as well as site editor.

I'm not sure what is different to have caused you to get the error, however I can see how the change you made would mitigate that, and running it in all the scenarios I could caused no harm so I'm fine bringing this change in.

@vcanales
Copy link
Member Author

@pbking Thanks for reviewing! Here's a screen capture of what I experience

Kapture.2023-06-27.at.12.10.14.mp4

@vcanales vcanales merged commit 0833d60 into trunk Jun 27, 2023
1 check passed
@mikachan mikachan deleted the fix/readme-recommended-plugin branch July 3, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants