Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache to docker builder #548

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Conversation

dmunozv04
Copy link
Contributor

@dmunozv04 dmunozv04 commented Jul 3, 2024

Proposed changes

Caches to and from GitHub actions (should improve build times), and only builds the wheel on one platform (prevents long build times for the platform agnostic wheel on arm64).
Additionally, there's now a step to login to quay.io (to be able to push images to that registry). Two new secrets, QUAY_USERNAME and QUAY_TOKEN are expected to be provided to be able to log in. Additionally an extra image field has to be added to the docker metadata step, with the name of the desired image on quay.

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

(should improve build times), and only build the wheel on one platform
@coveralls
Copy link

Coverage Status

coverage: 88.216% (+0.006%) from 88.21%
when pulling 6caffee on dmunozv04:dockerfile
into 2a25766 on Wirecloud:develop.

@coveralls
Copy link

Coverage Status

coverage: 88.216% (+0.006%) from 88.21%
when pulling 6caffee on dmunozv04:dockerfile
into 2a25766 on Wirecloud:develop.

@coveralls
Copy link

Coverage Status

coverage: 88.216% (+0.006%) from 88.21%
when pulling f3746b2 on dmunozv04:dockerfile
into 2a25766 on Wirecloud:develop.

@coveralls
Copy link

Coverage Status

coverage: 88.21%. remained the same
when pulling 78c34d0 on dmunozv04:dockerfile
into 2a25766 on Wirecloud:develop.

@coveralls
Copy link

Coverage Status

coverage: 88.21%. remained the same
when pulling 632c8f7 on dmunozv04:dockerfile
into 2a25766 on Wirecloud:develop.

@coveralls
Copy link

Coverage Status

coverage: 88.222% (+0.01%) from 88.21%
when pulling 210ec4a on dmunozv04:dockerfile
into 2a25766 on Wirecloud:develop.

@aarranz aarranz merged commit c4e942f into Wirecloud:develop Oct 16, 2024
37 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants