Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLATFORM-4908 Allow to add external image with custom url #21

Open
wants to merge 2 commits into
base: REL1_33_6-FANDOM
Choose a base branch
from

Conversation

mmeller-wikia
Copy link

@mmeller-wikia mmeller-wikia commented Feb 8, 2021

@mszabo-wikia
Copy link

Do we have a consensus on how we plan to implement this? This proposed implementation is different from the one submitted to upstream, and also different from the alternative suggested by upstream reviewers.

@mmeller-wikia
Copy link
Author

@mszabo-wikia Original patch (link] was rejected.
Based on second part of comment
2) I think just adjusting EXT_IMAGE_REGEX to allow trailing query parameters would likely be (a) a smaller patch, and (b) wouldn't involve an extra hook invocation on every URL. I'd think this would be preferable.
We prepared this patch -> we don't think that MW will agree to add sophisticated regex that will match links like this https://static.wikia.nocookie.net/olympians/images/c/c0/Luke_Castellan-Viria.jpg/revision/latest/top-crop/width/300/height/300?cb=20170220004745

@mszabo-wikia
Copy link

Can't know that without having a conversation about it first ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants