Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples are broken #401

Open
marcofugaro opened this issue Nov 27, 2019 · 5 comments
Open

Examples are broken #401

marcofugaro opened this issue Nov 27, 2019 · 5 comments

Comments

@marcofugaro
Copy link

marcofugaro commented Nov 27, 2019

Hi, I wanted to see the softbody example, however all the examples are broken ATM.
https://whs-dev.surge.sh/examples/#/physics/SoftBody/sphere

Shouldn't the examples use the stable 2.x version?

I have no way of viewing the example. I tried building the project locally, but didn't work as it gives me a of compilation errors when running npm run examples:

> gulp examples:build

[14:49:22] Requiring external module @babel/register
gulp examples:build[40876]: ../src/node_contextify.cc:640:static void node::contextify::ContextifyScript::New(const FunctionCallbackInfo<v8::Value> &): Assertion `args[1]->IsString()' failed.
 1: 0x100069fdc node::Abort() [/Users/marcofugaro/.npm/_npx/40869/bin/node]
 2: 0x100069903 node::GetErrorSource(v8::Isolate*, v8::Local<v8::Context>, v8::Local<v8::Message>, bool*) [/Users/marcofugaro/.npm/_npx/40869/bin/node]
 3: 0x100063292 node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [/Users/marcofugaro/.npm/_npx/40869/bin/node]
 4: 0x100240917 v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo*) [/Users/marcofugaro/.npm/_npx/40869/bin/node]
 5: 0x10023fbd8 v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<true>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/Users/marcofugaro/.npm/_npx/40869/bin/node]
 6: 0x10023f5b7 v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/Users/marcofugaro/.npm/_npx/40869/bin/node]
 7: 0x20eb76d4fc7d 
@hirako2000
Copy link
Collaborator

hirako2000 commented Dec 1, 2019

Hi @marcofugaro ,

I would rather try to use other script to build the project and run examples locally.
See npm run start.

with regards to the live examples, I will work on getting them to work and also update master branch examples to work again on the main site. Not sure exactly when though.

@aasim-syed
Copy link

image
the website is not responding

@Zaniyar
Copy link

Zaniyar commented Dec 18, 2021

still broken.

@hirako2000
Copy link
Collaborator

there are some issues with those href on the examples module. would anyone have time to help sorting this out? the examples are templated with react js.

@hirako2000
Copy link
Collaborator

I will give it a shot fixing the build errors across nodejs versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants