Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Dependency graph modifiable user regex #17

Open
jeremy-clerc opened this issue Apr 3, 2014 · 1 comment
Open

Feature: Dependency graph modifiable user regex #17

jeremy-clerc opened this issue Apr 3, 2014 · 1 comment

Comments

@jeremy-clerc
Copy link

For now when showing the dependency graph you can only choose all or the regex in the config. The idea would be to have a textfield to specify your regex expression.

@fgabolde
Copy link
Member

I'm not sure allowing users to provide regexen is a good idea. I don't think there is a security risk in doing so, assuming we are not running in the scope of a use re 'eval' statement, but I'm not confident that a regex can't be crafted to e.g. cause an infinite loop.

I think if a custom filter can be provided by the user, then it should be simpler than a regex. Regular wildcards should be sufficient for most needs, so Foo-* becomes ^Foo-.*$ and *-Bar becomes ^.*-Bar$.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants