Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add Functionality to Add PDFs from Amazon S3" #48

Open
nipunTharuksha opened this issue May 1, 2024 · 4 comments
Open

Comments

@nipunTharuksha
Copy link

Currently, the only way to add PDFs is through the function addPDF() that can only be linked to pdfs that already exist on the local, and integration or inclusion to the plugin to pull pdfs from Amazon S3 buckets before including them would be very useful to users. This addition would provide more flexibility and better user experience, helping users merge from pdfs in the cloud without necessarily downloading them locally.
For us to achieve this, we propose to add another function addPDFFromS3() to the plugin that will factor the file’s path on S3, and all the other parameters familiar with the existing addPDF() function.

@nipunTharuksha
Copy link
Author

PR raised #49

@gotDaijobu
Copy link

gotDaijobu commented Jun 4, 2024

I used Nipun's great solution that works well.

Had a few troubles though in production. I built a quick workaround using temp files locally hosted instead of S3 temp urls.

Available here.

@uevandalla
Copy link

nd integration or inclusion to the plugin to pull pdfs from Amazon S3 buckets before including them would be very useful to users. This addition would provide more flexibility

Does this also support Digital Ocean buckets?

@gotDaijobu
Copy link

Haven't tried it but they are supposed to be interoperable with S3 SDK/API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants