WIP: Implement Network Settings for Ubuntu Core - closes #3155 #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3155
This is a start on an experimental network settings back end for an Ubuntu or Ubuntu Core operating system, which configures network settings using NetworkManager via its DBus API. This will require implementing an async version of some
Platformmethods (which are currently all synchronous) all the way up the stack.I'm not sure yet whether we should use NetworkManger on both Ubuntu and Ubuntu Core, or just Ubuntu Core using #3165 to detect when we're running on Ubuntu Core.
This implementation will require requesting the
network-managerinterface for the snap package, which is not auto-connected by default in the Snap Store. We can make a request for a store assertion to make an exception to that rule, otherwise users will have to manually connect that interface on the command line.