-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Upgrade from Node 10 to Node 20 #3142
Draft
benfrancis
wants to merge
10
commits into
WebThingsIO:master
Choose a base branch
from
benfrancis:node20
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+19,933
−13,950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The next batch of TypeScript compile errors to fix:
|
You also want to update this: https://github.com/WebThingsIO/gateway/blob/master/.github/workflows/build.yml#L21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress PR to upgrade Node.js from version 10 to version 20 (the latest LTS) as per #3134.
So far I have just bumped the version in .nvmrc, run
npm install
to regenrate package-lock.json, runnpm update
to do minor version upgrades to dependencies and applied one small TypeScript fix.Ideally I would like to update all dependencies to their latest versions as per
npm outdated
, but first there are bunch more TypeScript errors to fix when you runnpm start
(which runs the TypeScript compiler).Any help would be appreciated.