Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebVR : Enable VR Mode for Aquarium #8

Open
shaoboyan opened this issue Jun 9, 2017 · 5 comments
Open

WebVR : Enable VR Mode for Aquarium #8

shaoboyan opened this issue Jun 9, 2017 · 5 comments

Comments

@shaoboyan
Copy link
Contributor

Currently, WebVR 1.1 is supported by lots of browsers, like firefox, chrome, etc. However , there isn't any ready benchmark or workload for browser based VR experience.
Since Aquarium is one of the famous benchmark of WebGL, we'd like to align it as the benchmark for browser based VR experience, too.
I've worked out the prototype of VR Mode for Aquarium now. And if you agree, I''m very happy to contribute this !

@greggman
Copy link
Contributor

greggman commented Jun 9, 2017

It's open source so feel free to do whatever you want with it.

If you'd like to check it in here I think at first I'd prefer it be in a different folder. The aqurium is in the aquarium folder, maybe the WebVR version could be in aquarium-vr

@shaoboyan
Copy link
Contributor Author

@greggman thx !

@shaoboyan
Copy link
Contributor Author

@greggman do you think it is the time aquarium-vr could merge into aquarium ? If not, is there any gap need to be filled?
P.S. aquarium-vr now support all of the feature aquarium has and doesn't affect normal aquarium rendering path.

Thx !

@greggman
Copy link
Contributor

What do you think about having a menu inside VR? Is that hard? (note I haven't looked at WebVR yet. I guess it probably doesn't support HTML in VR?). I also noticed the rays don't work in VR. Maybe just turn them off if in VR mode if they're not going to be fixed?

@shaoboyan
Copy link
Contributor Author

shaoboyan commented Oct 16, 2017

@greggman thx for replying!

  1. Have a menu inside VR : it is possible but need to include a-frame library to do it. I'd like to added a menu UI layer(when user click button, a UI layer will pop up, rendering scene will disappear, and user could use controller to modify it, close UI layer and see rendering scene again).
    Or I could try to write the whole UI with WebGL(some workloads, like create simple button, slides bar, controller model, controller ray and chosen effect... but I think it is possible for user to modify variable and see the result immediately). It is appreciate if you offer your suggestion :)
  2. Thx for your info about Rays issue. I think I'd like to fix this to align with original aquarium. Would you offer some suggestion on this issue ?
    P.S. Is rays issue means light ray in aquarium? I can see these light ray in vr mode. Could you give some more description of this issue? thx !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants