Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update references to HTML user activation behavior #2107

Closed
rtoy opened this issue Dec 6, 2019 · 0 comments · Fixed by #2110
Closed

Update references to HTML user activation behavior #2107

rtoy opened this issue Dec 6, 2019 · 0 comments · Fixed by #2110
Labels
Needs Edits Decision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/
Milestone
Web Audio V1

Comments

@rtoy
Copy link
Member

rtoy commented Dec 6, 2019

Describe the issue
The link for "triggered by user activation" no longer works.

Where Is It
In https://webaudio.github.io/web-audio-api/#AudioContext, see the paragraph just below the context IDL block.

Additional Information
This was updated in whatwg/html#5129 and whatwg/html#5129 (comment) has some guidelines on what to do.

Without fixing this, the doc has errors in it. (Well a new error.)
@rtoy rtoy mentioned this issue Dec 6, 2019
Merged
@padenot padenot mentioned this issue Dec 9, 2019
Open
14 tasks
padenot added a commit that referenced this issue Dec 9, 2019
@padenot
Update the spec to refer to the new activation mechanism in HTML
ff184b5 
This is intentionnaly vague to not restrict implementors: it's plausible
that an implementation chooses to be transient or sticky here.

This fixes #2107.
padenot added a commit to padenot/web-audio-api that referenced this issue Dec 9, 2019
@padenot
Update the spec to refer to the new activation mechanism in HTML
9fe4a74 
This is intentionaly vague to not restrict implementors: it's plausible
that an implementation chooses to be transient or sticky here.

This fixes WebAudio#2107.
@padenot padenot mentioned this issue Dec 9, 2019
Merged
@mdjp mdjp added this to the Web Audio V1 milestone Dec 12, 2019
@mdjp mdjp added the Needs Edits Decision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/ label Dec 12, 2019
padenot added a commit to padenot/web-audio-api that referenced this issue Dec 19, 2019
@padenot
Update the spec to refer to the new activation mechanism in HTML
a916f88 
This is intentionaly vague to not restrict implementors: it's plausible
that an implementation chooses to be transient or sticky here.

This fixes WebAudio#2107.

Address comments from Marcos

Don't use explicit link, and follow the guideline in https://github.com/whatwg/html/issues/5129\#issuecomment-562210730
padenot added a commit that referenced this issue Dec 19, 2019
@padenot
Update the spec to refer to the new activation mechanism in HTML
c6bba1c 
This is intentionaly vague to not restrict implementors: it's plausible
that an implementation chooses to be transient or sticky here.

This fixes #2107.

Address comments from Marcos

Don't use explicit link, and follow the guideline in https://github.com/whatwg/html/issues/5129\#issuecomment-562210730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Edits Decision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/
Projects
None yet
Milestone
Web Audio V1
Development

Successfully merging a pull request may close this issue.

Update the spec to refer to the new activation mechanism in HTML padenot/web-audio-api
3 participants
@padenot @rtoy @mdjp