Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a quick test case to verify a wasm runtime support range of WASI undefined functions? #53

Open
lum1n0us opened this issue Feb 3, 2023 · 1 comment

Comments

@lum1n0us
Copy link

lum1n0us commented Feb 3, 2023

There are two list of undefined functions in wasi-libc

IMO, a Wasm runtime announces to fully support WASI/WASI-thread should be able to provide all host implementations about `__imported_wasi_snapshot_preview1_XXX. Either via runtime itself(like WAMR) or via third-party(like uvwasi or cargo-wasi)

It would be able to verify the combability of variant versions WASI if there is a test. I understand the ultimate goal of was-testsuite is to verify that. But for now, Is there a quick check only about the range?

@loganek
Copy link
Collaborator

loganek commented Feb 3, 2023

Hi @lum1n0us , you're right, the goal is to verify:

  1. completeness
  2. correctness

of WASI implementation in the runtime. At the moment there's no way (at least in wasi-testsuite) to just verify if the function is supported (either correctly or incorrectly) by the runtime; once we have a full coverage, you should be able to to do that, but we still miss a number of functions in test suite.

I'd keep this issue open so as part of this ticket we can implement a set of a sanity checks that hopefully satisfy your requirement short term. Feel free to contribute your tests to this repository too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants