Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec testsuite #80

Open
dhil opened this issue Aug 28, 2024 · 3 comments
Open

Spec testsuite #80

dhil opened this issue Aug 28, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@dhil
Copy link
Member

dhil commented Aug 28, 2024

We should develop the spec testsuite for the stack switching proposal. We have something implemented already in (cont.wast, validation.wast, validation_gc.wast), however it does not thoroughly test switch and it could do a better job of testing interactions with other proposals (exception handling and gc would be of particular interest, I think).

@dhil dhil added the enhancement New feature or request label Aug 28, 2024
@rossberg
Copy link
Member

Good idea. We should structure it along the lines of other proposals, i.e., a cont/ (or stack/) subdirectory, and separate wast files per instruction tested, where possible.

@frank-emrich
Copy link
Collaborator

frank-emrich commented Aug 28, 2024

Do the tests for other proposals usually separate the tests for validation from those for execution in some way? We do have some tests that attempt to cover every aspect of the validation of wasmfx instructions here and here.

I'm happy to split these into per-instruction files, but I'm wondering about the file structure beyond that. For example, the existing file structure makes sure that everything depending on GC lives in its own file, so we can use these files to also use these tests on engines that don't implement GC yet.

@rossberg
Copy link
Member

So far, validation and execution isn't split anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants