[interpreter] Update Makefile to ignore output of cd
#1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interpreter Makefile captures the output of cding into the unittest directory and listing the unittest files it contains. Under some circumstances, the `cd` command will print the new current directory, and that output was incorrectly being interpreted as the path to a unittest, causing the build to fail. Fix this problem by redirecting the output of cd, if any, to /dev/null. Fixes #1681.
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
rossberg
approved these changes
Sep 21, 2023
|
Oh, you might wanna do the same for TESTFILES. |
|
done, thanks |
rossberg
pushed a commit
that referenced
this pull request
Oct 13, 2023
The interpreter Makefile captures the output of cding into the unittest directory and listing the unittest files it contains. Under some circumstances, the `cd` command will print the new current directory, and that output was incorrectly being interpreted as the path to a unittest, causing the build to fail. Fix this problem by redirecting the output of cd, if any, to /dev/null. Fixes #1681.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interpreter Makefile captures the output of cding into the unittest
directory and listing the unittest files it contains. Under some circumstances,
the
cdcommand will print the new current directory, and that output wasincorrectly being interpreted as the path to a unittest, causing the build to
fail.
Fix this problem by redirecting the output of cd, if any, to /dev/null.
Fixes #1681.