Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve descriptions and fix a few examples in Explainer.md #339

Merged
merged 9 commits into from
Apr 30, 2024
Merged

Conversation

lukewagner
Copy link
Member

This PR should be purely editorial, addressing feedback in #276. The only thing potentially interesting to folks is the 3 WAT example fixes in Explainer.md (all making the same mistake, which is binding the $identifier in the wrong place for exports in type context).

Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukewagner
Copy link
Member Author

lukewagner commented Apr 17, 2024

Update: I added 3 4 more commits (expanding documentation) based on further comments.

@lukewagner lukewagner merged commit 8906654 into main Apr 30, 2024
2 checks passed
@lukewagner lukewagner deleted the tweaks branch April 30, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants