-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments/Questions #276
Comments
Awesome, thanks so much! I'll definitely go through the comments and either turn them into PRs or ask questions here or open new issues, as appropriate. |
Oops, this fell off my radar, but I started going through all the comments just now. I started with a first pass that simply fixes typos in this commit. For the rest, I'll submit some PRs so they can be reviewed. |
Thanks, I left a few more replies. |
(Also filed #351.) |
Ok, with #353 filed, I think I've gone through all the comments. Thanks a lot for all the feedback and suggestions! |
Great, thanks for filing #356 for discussion. I'll close this issue b/c I think that's everything, but feel free to reopen if there's anything missing, or file new issues. |
I finally did an end-to-end read of all (well, most of) the docs in this repo. Since GH doesn't offer a means to comment on committed files, I created a dummy repo with a dummy PR of the entire content here and left my comments & questions there. Hope that indirection works well enough. :)
Overall, this looks great. I found the explainer particularly helpful and very well-written.
Happy to open individual issues for some of my comments/suggestions if they turn out to be relevant.
The text was updated successfully, but these errors were encountered: