Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments/Questions #276

Closed
rossberg opened this issue Nov 29, 2023 · 7 comments
Closed

Comments/Questions #276

rossberg opened this issue Nov 29, 2023 · 7 comments

Comments

@rossberg
Copy link
Member

I finally did an end-to-end read of all (well, most of) the docs in this repo. Since GH doesn't offer a means to comment on committed files, I created a dummy repo with a dummy PR of the entire content here and left my comments & questions there. Hope that indirection works well enough. :)

Overall, this looks great. I found the explainer particularly helpful and very well-written.

Happy to open individual issues for some of my comments/suggestions if they turn out to be relevant.

@lukewagner
Copy link
Member

Awesome, thanks so much! I'll definitely go through the comments and either turn them into PRs or ask questions here or open new issues, as appropriate.

lukewagner added a commit that referenced this issue Apr 11, 2024
@lukewagner
Copy link
Member

Oops, this fell off my radar, but I started going through all the comments just now. I started with a first pass that simply fixes typos in this commit. For the rest, I'll submit some PRs so they can be reviewed.

@lukewagner
Copy link
Member

Ok, I went through all the comments and either replied inline or folded the feedback into #339 or #341. Happy to discuss more inline in those comment threads or on the above PRs or here.

@rossberg
Copy link
Member Author

Thanks, I left a few more replies.

@lukewagner
Copy link
Member

(Also filed #351.)

@lukewagner
Copy link
Member

Ok, with #353 filed, I think I've gone through all the comments. Thanks a lot for all the feedback and suggestions!

@lukewagner
Copy link
Member

Great, thanks for filing #356 for discussion. I'll close this issue b/c I think that's everything, but feel free to reopen if there's anything missing, or file new issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants