Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match end sound effect #658

Open
ghost opened this issue Jun 9, 2020 · 8 comments
Open

Match end sound effect #658

ghost opened this issue Jun 9, 2020 · 8 comments
Labels

Comments

@ghost
Copy link

ghost commented Jun 9, 2020

Describe the bug
At the end of each match, there's an awful loud sound which plays.
Edit: Also when wool is grabbed.

Client version
1.15.x

To Reproduce
Steps to reproduce the bug:

  1. Play either in a match or as a spectator.
  2. Wait for a match to end.

Expected behavior
A softer sound effect.

Server Software (Spigot/PaperSpigot):
PaperSpigot

@ghost ghost added the bug label Jun 9, 2020
@nichxlxs
Copy link

Is the problem that the sound is too loud or the sound should be changed to something else?

@ghost
Copy link
Author

ghost commented Jun 16, 2020

The sound is too loud. Therefore, I'm recommending either lower the volume of the sound, or change it overall.

@benrobson
Copy link
Contributor

The sound is too loud. Therefore, I'm recommending either lower the volume of the sound, or change it overall.

Is this still a recurring issue since June 2020?

@Owehttamy
Copy link

Still a recurring issue

@benrobson
Copy link
Contributor

In my recent change from just above this, you can change the volume from the Ambient sound category in game.
Give this a try and let me know how it goes.

@benrobson
Copy link
Contributor

Make sure you are operating on the latest commit.

@Owehttamy
Copy link

Yes, this is still apparent, as seen here (volume warning, of course)
Just to clarify: the changes did seem to fix the KOTH, CTW, and DTM sounds effects, but they didn't fix the match end sound effect.

@benrobson
Copy link
Contributor

Where the match end sound effect is: https://github.com/benrobson/TGM/blob/fix-end-match-sound/TGM/src/main/java/network/warzone/tgm/modules/MatchResultModule.java#L63
In accordance with the provided footage, it is ignoring AMBIENT.

@jellz @jorgeberrex is this called anywhere else?
Thought I replaced these in the entire project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants