Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strip_tags to ScssViewHelper in case of inline content #72

Open
foppelfb opened this issue Jul 5, 2023 · 0 comments
Open

Add strip_tags to ScssViewHelper in case of inline content #72

foppelfb opened this issue Jul 5, 2023 · 0 comments

Comments

@foppelfb
Copy link

foppelfb commented Jul 5, 2023

This is more of a Developer / Integrator usability issue.

When writing inline scss in a FluidTemplate PHPStorm has a hard time formatting the scss code, especially when copy pasting or indenting.

<scss:asset.scss identifier="container-25" forcedOutputLocation="file" scssVariables="{settings.scss}">
        .element-container_25 {
       div {
       padding: 1rem;   
        }
        }
</scss:asset.scss>

A simple <style type="text/scss"> would help:

<scss:asset.scss identifier="container-25" forcedOutputLocation="file" scssVariables="{settings.scss}">
        <style type="text/scss">
        .element-container_25 {
            div {
                padding: 1rem;   
             }
        }
       </style>
</scss:asset.scss>

now PHPStorm will treat that content-block as CSS/SCSS and support indentation and value expansion. this would be a big time-saver

But in order for that to work the <style> Tag would have to be stripped before it is paresed. The attached patch shows a possible example to implement this

WapplerSystemsWsScssAddStripTagsToViewHelper.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant