From 87f228e1dfa04d518b5a31b35b5b572f6b997eca Mon Sep 17 00:00:00 2001 From: Barsik Date: Tue, 14 May 2024 01:38:55 +0300 Subject: [PATCH] Logic for bumping of a crate version has been changed Before we updated the highest part of the version, now we will focus on the minor part of the version --- module/move/willbe/src/entity/version.rs | 9 ++------- module/move/willbe/tests/inc/entity/version.rs | 6 +++--- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/module/move/willbe/src/entity/version.rs b/module/move/willbe/src/entity/version.rs index d20329839e..efbc5b4b0c 100644 --- a/module/move/willbe/src/entity/version.rs +++ b/module/move/willbe/src/entity/version.rs @@ -68,13 +68,8 @@ mod private pub fn bump( self ) -> Self { let mut ver = self.0; - if ver.major != 0 - { - ver.major += 1; - ver.minor = 0; - ver.patch = 0; - } - else if ver.minor != 0 + // we shouldn't change the major part of a version yet + if ver.minor != 0 || ver.major != 0 { ver.minor += 1; ver.patch = 0; diff --git a/module/move/willbe/tests/inc/entity/version.rs b/module/move/willbe/tests/inc/entity/version.rs index 328bd07834..6ae36602ce 100644 --- a/module/move/willbe/tests/inc/entity/version.rs +++ b/module/move/willbe/tests/inc/entity/version.rs @@ -71,7 +71,7 @@ fn major_without_patches() let new_version = version.bump(); // Assert - assert_eq!( "2.0.0", &new_version.to_string() ); + assert_eq!( "1.1.0", &new_version.to_string() ); } #[ test ] @@ -84,7 +84,7 @@ fn major_with_minor() let new_version = version.bump(); // Assert - assert_eq!( "2.0.0", &new_version.to_string() ); + assert_eq!( "1.2.0", &new_version.to_string() ); } #[ test ] @@ -97,7 +97,7 @@ fn major_with_patches() let new_version = version.bump(); // Assert - assert_eq!( "2.0.0", &new_version.to_string() ); + assert_eq!( "1.2.0", &new_version.to_string() ); } #[ test ]