Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solana Transaction Signing Failing #4589

Open
deadeagle63 opened this issue Jun 6, 2024 · 2 comments
Open

Solana Transaction Signing Failing #4589

deadeagle63 opened this issue Jun 6, 2024 · 2 comments
Labels
type: bug Something isn't working

Comments

@deadeagle63
Copy link

Description:
Currently whenever a transaction is signed with the Solana mainnet chainId as per the SUPPORTED_CHAINS.md it fails with a -32000 code and a message of transaction failed to send.

SDK(s): (based off of JonWong repo above)
@walletconnect/modal ^2.6.2
@walletconnect/sign-client ^2.10.6
@walletconnect/utils ^2.10.6

Steps to reproduce the behavior:

  1. Go to https://feature-walletconnect-fix.doi1f799swne9.amplifyapp.com/ (GooseFX feature link or clone the repo)
  2. Click on 'Connect Wallet' button and connect with a WalletConnect wallet
  3. Scroll down to any of the pools and stake 0.01 USDC
  4. See error

Expected behavior
Expect a transaction to succeed if the conditions are correct i.e user has the correct wallet balance or token account.

Screenshots
Loom to help

Desktop (please complete the following information):

  • OS: MacOS 14.4
  • Browser: Arc
  • Version: 1.43

Additional context
Preface, currently the Solana chain uses Wallet-Adapter as its base for interacting with core supported adapters. As of time writing this, the WalletConnect adapter used is primarily sourced from Jon Wong's implementation, due to his PR being stuck in limbo for upping the version I copy-pasta'd the implementation with the updated code @ GooseFX WalletConnect Fix.

@deadeagle63 deadeagle63 added the type: bug Something isn't working label Jun 6, 2024
Copy link

linear bot commented Jun 6, 2024

@deadeagle63
Copy link
Author

deadeagle63 commented Jun 10, 2024

On further testing/investigation - I believe this is to be caused by Legacy Transactions. Moving to VersionedTransactions they sign and send perfectly. If this is expected I assume this can be closed.

[Edit]
Seems like trust wallet fails using the new chainId when trying to send, but wont connect on old chainId - had a false positive due to Exodus wallet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant