Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow localhost #82

Merged
merged 1 commit into from
Jun 26, 2024
Merged

feat: allow localhost #82

merged 1 commit into from
Jun 26, 2024

Conversation

chris13524
Copy link
Member

Description

Always allows localhost domains, with any scheme and any port.

How Has This Been Tested?

New tests & manually

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this Jun 25, 2024
Copy link
Member

@xDarksome xDarksome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're hardcoding it here, then it can be removed from Domain

@chris13524
Copy link
Member Author

If you're hardcoding it here, then it can be removed from Domain

@xDarksome what do you mean?

@chris13524 chris13524 merged commit 3147ca7 into main Jun 26, 2024
11 of 12 checks passed
@chris13524 chris13524 deleted the feat/allow-localhost branch June 26, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants