Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine / and /index.js endpoints for performance #67

Closed
chris13524 opened this issue Feb 12, 2024 · 1 comment
Closed

Combine / and /index.js endpoints for performance #67

chris13524 opened this issue Feb 12, 2024 · 1 comment
Assignees
@chris13524
Labels
accepted The issue has been accepted into the project good first issue Good for newcomers

Comments

@chris13524
Copy link
Member

The second endpoint just substitutes the token query param into the source code, but the JavaScript could be served in the first response as inline JavaScript. This will halve the req/s.

Slack conversation
@chris13524 chris13524 added the good first issue Good for newcomers label Feb 12, 2024
@arein arein added the accepted The issue has been accepted into the project label Feb 12, 2024
@chris13524 chris13524 self-assigned this Feb 12, 2024
@chris13524 chris13524 mentioned this issue Feb 22, 2024
Closed
3 tasks
@chris13524
Copy link
Member Author

Fixed in rewrite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chris13524 chris13524

Labels
accepted The issue has been accepted into the project good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: combine requests WalletConnect/verify-server
2 participants
@arein @chris13524