Simplify takeUntil() unsubscription
#121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
added a commit
that referenced
this pull request
Feb 20, 2024
SHA: 4e61306 Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL introduces no behavior change to the
takeUntil()operator, it only implements a simplification. Prior to this PR,takeUntil()declared an AbortController which managed an AbortSignal that fed into thesourceObservableandnotifierObservable subscriptions. This was so that the two Observables could trigger unsubscriptions to each other, if i.e.,sourceObservablecompletes, or ifnotifiernext()s or errors()s.But I didn't realize that we don't actually have to do that. As long as those operations either "complete" or "error" the "outer"
Subscriber(that is associated with the Observable returned fromtakeUntil()), then the outer Subscriber's signal will be aborted, and we can simply use that AbortSignal as the input to the subscription ofsourceObservableandnotifierand have the same effect, without needing to maintain our own AbortController.I am merging this myself since I implemented this as part of https://crrev.com/c/5311097 and found that there was no observable (pun) behavior change, as expected.
Preview | Diff