Update example for Usage Metrics, fix incorrect use of username which should be domain, add simulated API call example, add code comments #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… should be domain. Provide a simulated API call example code and add code comments
|
Found this related discussion which is relevant to these changes, https://whmcs.community/topic/297347-usage-metrics-not-updating/ |
|
And also this feature request, https://requests.whmcs.com/idea/make-field-to-use-for-tenantusage-configurable |
|
I realise now too that this PR's apiCall example is still incorrect and should be improved. I'll do that too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was struggling to get the Usage Metrics working correctly when called by WHMCS cron, it turns out that the example code was incorrect.
This PR updates the example code for Usage Metrics.