Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vertices_latitude / vertices_longitude should not have attribute units #68

Open
larsbuntemeyer opened this issue Feb 13, 2024 · 3 comments
Labels
wontfix This will not be worked on

Comments

@larsbuntemeyer
Copy link
Contributor

larsbuntemeyer commented Feb 13, 2024

I am not sure why this is the case for the CMIP6_grids.json table but i think we should not have the units attribute in the boundary variables according to CF conventions:

"vertices_latitude": {
"standard_name": "",
"units": "degrees_north",
"long_name": "",
"dimensions": "vertices longitude latitude",
"out_name": "vertices_latitude",
"valid_min": "-90.0",
"valid_max": "90.0",
"type": "double"
},
"vertices_longitude": {
"standard_name": "",
"units": "degrees_east",
"long_name": "",
"dimensions": "vertices longitude latitude",
"out_name": "vertices_longitude",
"valid_min": "-180.0",
"valid_max": "180.0",
"type": "double"
}

@larsbuntemeyer
Copy link
Contributor Author

see PCMDI/cmor#729

@gnikulin
Copy link

gnikulin commented Mar 14, 2024

I agree, the units attribute in the boundary variables is redundant information and the boundary variables shouldn't have any attributes, also consistent with the CF conventions.

@larsbuntemeyer
Copy link
Contributor Author

OK, we can't really do anything about what cmor will write out here i guess. But the way it is now should be fine since these are recommendations. I'll leave the issue open anyway..

@larsbuntemeyer larsbuntemeyer added the wontfix This will not be worked on label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants