You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looking at this PR I can't help but notice there is some common, yet complicated, logic in the workflows regarding entitlement checks. It might make sense to adopt the following process to ease maintenance of this logic.
Use a Makefile (or similar) to cause the various .yml files to be assembled such that the duplicate logic is templated from one source file into several .yml files. For example, I observe the logic in Deploy VM using image for evaluation usage is in at least two .yml` files.
Adopt the policy that when making changes to the workflows, the human makes the changes in the file(s) that serve as input to make and then runs make before committing the work to git.
Put sufficient warning is the .yml files that are generated by make advising future humans to not edit the files directly, but rather to edit whatever source files go in to make.
Of course, you don't have to use make. Any templating system would work. Perhaps even shell scripts.
The text was updated successfully, but these errors were encountered:
Looking at this PR I can't help but notice there is some common, yet complicated, logic in the workflows regarding entitlement checks. It might make sense to adopt the following process to ease maintenance of this logic.
Makefile
(or similar) to cause the various.yml
files to be assembled such that the duplicate logic is templated from one source file into several.yml
files. For example, I observe the logic inDeploy VM using image for evaluation usage is in at least two
.yml` files.make
and then runsmake
before committing the work to git..yml
files that are generated bymake
advising future humans to not edit the files directly, but rather to edit whatever source files go in tomake
.Of course, you don't have to use
make
. Any templating system would work. Perhaps even shell scripts.The text was updated successfully, but these errors were encountered: