New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape translation string injections to JS files. #131

Open

kaspar-naaber opened this issue Nov 6, 2017 · 1 comment

Labels

bug

Contributor

kaspar-naaber commented Nov 6, 2017

If translation string contains single quotes it will break the JS code (problem exists in Nederlands language).

kaspar-naaber added the bug label

Contributor Author

kaspar-naaber commented Dec 4, 2017

For example the following injection...

site.bindContentItemImgDropAreas('{{ "drag_picture_for_product_here" | lc }}');

..should be escaped like this:

site.bindContentItemImgDropAreas('{{ "drag_picture_for_product_here" | lc | escape }}');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment