Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink naming for Plugin.Bundled and Plugin.BundledCrossVersion #304

Open
LukaszKontowski opened this issue Oct 26, 2022 · 1 comment
Open

Rethink naming for Plugin.Bundled and Plugin.BundledCrossVersion #304

LukaszKontowski opened this issue Oct 26, 2022 · 1 comment

Comments

@LukaszKontowski
Copy link
Contributor

As discussed here: #300 (comment) and here: #300 (comment) - current naming convention for these two Plugin types and their fields (& connected HOCON configs) might be misleading for users.

For most IntelliJ users - "bundled IntelliJ plugin" means included with IntelliJ by default. In case of Plugin.Bundled and Plugin.BundledCrossVersion - the meaning of "bundle" / "bundled" word is something else. We can think of renaming these parts of ide-probe so that we stop using the "bundled"/"bundle" words to avoid confusion.
@LukaszKontowski
Copy link
Contributor Author

@lukaszwawrzyk - please share your point of view on this issue 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LukaszKontowski