Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from GreenDao to something else #6

Open
Vinetos opened this issue Mar 23, 2024 · 10 comments
Open

Migrate from GreenDao to something else #6

Vinetos opened this issue Mar 23, 2024 · 10 comments
Assignees
Labels
bug Something isn't working high priority

Comments

@Vinetos
Copy link
Owner

Vinetos commented Mar 23, 2024

GreenDAO is not FOSS as the gradle plugin is still not opens-sourced.
greenrobot/greenDAO#412
We have to select another database library in order to be FOSS and be published on F-Droid

@Vinetos Vinetos added bug Something isn't working high priority labels Mar 23, 2024
@Penaz91
Copy link

Penaz91 commented Mar 26, 2024

Hello! I have been following the development of this fork since I saw your post on YACB's gitlab. Seems that another repository I follow has run onto the same issue as yours: breezy-weather/breezy-weather#677

In this precise case, SQLDelight was used, but the issue lists some alternatives that you may want to check out. Hopefully this helps a bit!

@Vinetos
Copy link
Owner Author

Vinetos commented Mar 27, 2024

Hello !
Thank you for letting me know. I am currently looking for an alternative that could match the current behaviour.

I will have a look at this issue to see how they resolved this !

@Vinetos
Copy link
Owner Author

Vinetos commented Apr 3, 2024

SQLDelight seems to be an good alternative and make the transition path easy enough. I think this it what we will use.

@Vinetos
Copy link
Owner Author

Vinetos commented Apr 30, 2024

I am pinning this issue as it takes me a lot of work before doing other one !

@licaon-kter
Copy link

Can you drop the plugin and include the generated part, eg: wallabag/android-app#1406

@Vinetos
Copy link
Owner Author

Vinetos commented May 29, 2024

Yep, that something I will do very soon.

@linsui
Copy link

linsui commented Jun 12, 2024

The source code is published.

@Vinetos
Copy link
Owner Author

Vinetos commented Jun 12, 2024

If the plugin is effectively the one used, migration to the open-srouced version will be easier as YACB is strongly linked to greenDAO work.
I have notified F-Droid team that greenDAO is open-sourced, if the app is then accepted to the store, I will close this issue or mark it as "good to have one day".

@licaon-kter
Copy link

@Vinetos you do know that https://github.com/greenrobot/greenDAO (the actual reason for the plugin) is no longer developed right?

@Vinetos
Copy link
Owner Author

Vinetos commented Jun 12, 2024

Indeed, transitioning to SQLDelight is on my agenda, albeit it's more of a desirable enhancement rather than an immediate necessity. In my perspective, the majority of the work for SQLDelight has been accomplished. However, due to time constraints, I haven't been able to finalize and thoroughly test the migration process.

Probably a two step transition is possible and easier to perform :
1 - remove greendao and use generated models as-it-is
2 - add sqldelight for a better database management

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Projects
Status: In progress
Development

No branches or pull requests

4 participants