Add i18n supports for Korean #333
Open
+88
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Vimux Check this pr asap, plz! 😄 |
Vimux
requested changes
Jul 15, 2023
| translation: "주의" | ||
|
|
||
| - id: sidebar_recommendation | ||
| translation: "하나 이상의 사이드바 위젯(params.sidebar.widgets)을 활성화해 주시기 바랍니다." |
There was a problem hiding this comment.
sidebar_recommendation:
It should be consistent with the other translations. Do not specify a specific parameter (params.sidebar.widgets).
| translation: "<b>$HUGE_HOME/content</b> 디렉토리 아래에 게시물(*.md)을 게시하면 여기에 표시됩니다.<br />기본적으로, 가장 많은 글이 있는 하나의 섹션을 기준으로 합니다." | ||
|
|
||
| - id: noposts_warning_tip | ||
| translation: 'Tip: <a href="https://gohugo.io/functions/where/#mainsections" rel="nofollow noopener" target="_blank">params.mainSections</a> 설정 매개변수를 사용하여, 원하는 만큼의 섹션을 표시할 수 있습니다.' |
There was a problem hiding this comment.
noposts_warning_tip:
- Use double quotes (escape the double quotes inside).
- params.mainSections -> mainSections.
It should be consistent with the other translations. Do not use a specific parameter (params.mainSections).
| translation: "표시할 게시물이 없습니다!" | ||
|
|
||
| - id: noposts_warning_description | ||
| translation: "<b>$HUGE_HOME/content</b> 디렉토리 아래에 게시물(*.md)을 게시하면 여기에 표시됩니다.<br />기본적으로, 가장 많은 글이 있는 하나의 섹션을 기준으로 합니다." |
There was a problem hiding this comment.
noposts_warning_description: Please try to rephrase closer to the original if possible. If not, get rid of direct references to specific formats and dirs. Reasons:
$HUGE_HOME/content? Hugo supports different content dirs. In the default language, we specify that users should put the post in the content directory. Content directory is not always directly equal to./content.(*.md)? Hugo supports multiple content formats. Stating only one specific (*.md) is not correct and causes more confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I really like mainroad theme.
However, since there is no Korean language support, I make PR.
I hope for your positive review. 😃