Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve response from backend when there are different fields returns #29

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

dmitryk-dk
Copy link
Contributor

@dmitryk-dk dmitryk-dk commented Jun 21, 2024

Fixed issue if the response returns different fields. It creates more generic behavior to prepare responses for UI.
Sometimes, the response can't include a time value and line values, so it should be generated manually from the returned label values

Related issue: #23

Copy link
Contributor

@hagen1778 hagen1778 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments. And please add a changelog explaining this change.

pkg/plugin/response.go Show resolved Hide resolved
pkg/plugin/response.go Outdated Show resolved Hide resolved
pkg/plugin/response.go Outdated Show resolved Hide resolved
pkg/plugin/response.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@hagen1778 hagen1778 merged commit 542fee9 into main Jun 24, 2024
5 checks passed
@zekker6 zekker6 deleted the issue-23 branch June 24, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants