Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmauth: allow override default config #1123

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AndrewChubatiuk
Copy link
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Oct 4, 2024

In a case described here user utilises vault sidecar for configuration generation, which is not currently supported by operator.
Added ability to disable config reloader if auth.config is defined in extraArgs for vmauth spec

fixes #1125

@f41gh7
Copy link
Collaborator

f41gh7 commented Oct 5, 2024

I think, it's better to add some kind of config source field at vmauth.spec.

Which should contain enum of possible sources for unmanaged version of vmauth.

Because, current change creates some kind of undocumented hack and this behavior could be non-intuitive for users.

WDYT of kind.spec.ExternalConfigSource, which current has the following values:

  • undefined ( nil value) - configuration managed by operator. Default behavior.
  • secretRef - (key,name) for secret with configuration. Replaces deprecated SecretConfig.
  • localPath - string for locally mounted secrets.

Goal of this change - provide clear example, when configuration managed by operator and when it's not.

cc @Haleygo

@f41gh7
Copy link
Collaborator

f41gh7 commented Oct 5, 2024

It also, would be great to create an issue with propose change. To keep track of motivation and discussion of proposed changes (slack keeps history only for 3 months atm).

@AndrewChubatiuk
Copy link
Contributor Author

Replaced configSecret with externalConfig, which includes secretRef and localPath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vmauth: add ability to provide external configuration via Vault Sidecar
2 participants