Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed default fluentbit config, use headers instead of query args #1526

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fixed default fluentbit config, use headers instead of query args #1526

merged 1 commit into from
Sep 23, 2024

Conversation

AndrewChubatiuk
Copy link
Contributor

fixes #1525

@AndrewChubatiuk AndrewChubatiuk merged commit fa2fd5a into master Sep 23, 2024
8 checks passed
@AndrewChubatiuk AndrewChubatiuk deleted the fixed-fluentbit-default-config branch September 23, 2024 18:12
@Andrey36652
Copy link

What is the reason to use headers instead of query params?

@AndrewChubatiuk
Copy link
Contributor Author

better readability, do you have any objections?

@Andrey36652
Copy link

No, I thought it is some kind of functional difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zekker6 zekker6 zekker6 approved these changes

@Haleygo Haleygo Awaiting requested review from Haleygo Haleygo is a code owner

@f41gh7 f41gh7 Awaiting requested review from f41gh7 f41gh7 is a code owner

Assignees
No one assigned
Labels
logs-single
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[victoria-logs-single] Extra quotes on fluent-bit default host definition, no upstream connection
3 participants
@AndrewChubatiuk @Andrey36652 @zekker6