From ac5b2b3456573d9e7ed53d10090eec56f473d9b0 Mon Sep 17 00:00:00 2001
From: Andrii Chubatiuk <achubatiuk@victoriametrics.com>
Date: Fri, 11 Oct 2024 10:15:55 +0300
Subject: [PATCH] common: readable error on helm older than 3.14 (#1579)

---
 charts/victoria-metrics-common/CHANGELOG.md           | 2 +-
 charts/victoria-metrics-common/Chart.yaml             | 2 +-
 charts/victoria-metrics-common/templates/_helpers.tpl | 4 ++++
 3 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/charts/victoria-metrics-common/CHANGELOG.md b/charts/victoria-metrics-common/CHANGELOG.md
index d5bd92c11..19ae924f8 100644
--- a/charts/victoria-metrics-common/CHANGELOG.md
+++ b/charts/victoria-metrics-common/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 ## Next release
 
-- TODO
+- Display compatibility error message
 
 ## 0.0.14
 
diff --git a/charts/victoria-metrics-common/Chart.yaml b/charts/victoria-metrics-common/Chart.yaml
index 2a8cdbd71..99b783a7c 100644
--- a/charts/victoria-metrics-common/Chart.yaml
+++ b/charts/victoria-metrics-common/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 type: library
 description: Victoria Metrics Common - contains shared templates for all Victoria Metrics helm charts
 name: victoria-metrics-common
-version: 0.0.14
+version: 0.0.15
 sources:
   - https://github.com/VictoriaMetrics/helm-charts
 kubeVersion: ">=1.23.0-0"
diff --git a/charts/victoria-metrics-common/templates/_helpers.tpl b/charts/victoria-metrics-common/templates/_helpers.tpl
index b784dda1a..f3b489e82 100644
--- a/charts/victoria-metrics-common/templates/_helpers.tpl
+++ b/charts/victoria-metrics-common/templates/_helpers.tpl
@@ -1,6 +1,10 @@
 {{- define "vm.namespace" -}}
   {{- $Release := (.helm).Release | default .Release -}}
   {{- $Values := (.helm).Values | default .Values -}}
+  {{- $Capabilities := (.helm).Capabilities | default .Capabilities -}}
+  {{- if semverCompare "<3.14.0" $Capabilities.HelmVersion.Version }}
+    {{- fail "This chart requires helm version 3.14.0 or higher" }}
+  {{- end }}
   {{- $Values.namespaceOverride | default ($Values.global).namespaceOverride | default $Release.Namespace -}}
 {{- end -}}