Move protocol detector injection outside of sync block #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianMichael
requested changes
Aug 23, 2024
There was a problem hiding this comment.
MixinExtras got added with Fabric Loader 0.15.0 and we enforce >=0.15.11 which means we can use MixinExtras (and also should for mod compatibility).
Can you reproduce the issue on 1.20.1? I can't, and if you also can't please revert the changes made to the 1.20.1 submodule.
|
I can't reproduce it on 1.20.1 with 0.4.15+81-main, I shall revert then. |
...ain/java/com/viaversion/fabric/mc1204/mixin/pipeline/client/MixinClientConnectionThread.java
Outdated
Show resolved
Hide resolved
FlorianMichael
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses MixinExtras for local capturing; can be changed to a different method, or JiJ MixinExtras to maintain older Fabric Loader support if wanted.
Applies to 1.20.1+
Fixes #302