Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change darkness->blindness in 1.19->1.18.2 #908

Merged
merged 6 commits into from
Nov 7, 2024
Merged

Change darkness->blindness in 1.19->1.18.2 #908

merged 6 commits into from
Nov 7, 2024

Conversation

FlorianMichael
Copy link
Member

No description provided.

kennytv
kennytv requested changes Nov 3, 2024
View reviewed changes
Copy link
Member

@kennytv kennytv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to also handle remove effects

@FlorianMichael
Copy link
Member Author

Done, now added a config option as well.

@FlorianMichael FlorianMichael marked this pull request as draft November 3, 2024 18:57
@FlorianMichael FlorianMichael marked this pull request as ready for review November 3, 2024 19:17
@kennytv kennytv merged commit 8cb285d into master Nov 7, 2024
2 checks passed
@kennytv kennytv deleted the fix/darkness branch November 7, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytv kennytv kennytv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorianMichael @kennytv