Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update copyright year in Windows Runner.rc #188

Merged
merged 10 commits into from
Aug 28, 2024

Conversation

Antoniobox
Copy link
Contributor

Description

This PR introduces a dynamic current_year variable to the project templates, allowing the copyright year to be automatically updated based on the current year. This change ensures that the copyright message is always accurate and up-to-date without requiring manual updates each year.

Changes

  • Added current_year variable to automatically reflect the current year.
  • Updated copyright messages to use the current_year variable instead of a static year.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@Antoniobox Antoniobox requested a review from a team as a code owner August 26, 2024 15:44
@Antoniobox
Copy link
Contributor Author

Related Issue: #162

Copy link
Contributor

@alestiago alestiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good! Thanks for the contribution.

I would like us to use the clock package as a dev dependency to fake the current time, would that be possible?

very_good_core/hooks/test/pre_gen_test.dart Outdated Show resolved Hide resolved
alestiago
alestiago previously approved these changes Aug 28, 2024
Copy link
Contributor

@alestiago alestiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for the contribution! The same change needs to be applied to the Flame Game, let me know if you would like to contribute there!

Pushed some small changes, I think it's ready for getting it merged!

alestiago
alestiago previously approved these changes Aug 28, 2024
@Antoniobox
Copy link
Contributor Author

Looks good to me! Thank you for the contribution! The same change needs to be applied to the Flame Game, let me know if you would like to contribute there!

Pushed some small changes, I think it's ready for getting it merged!

I'm thrilled to collaborate on this issue and others as well! I'd be happy to help with the same change for the Flame Game. Thank you for the feedback and for pushing the final changes—glad to see it’s ready to be merged!

@alestiago alestiago added this pull request to the merge queue Aug 28, 2024
Merged via the queue into VeryGoodOpenSource:main with commit 6c1c7ab Aug 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants