Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update application identifier #148

Merged
merged 11 commits into from
Jul 23, 2024
Merged

fix: update application identifier #148

merged 11 commits into from
Jul 23, 2024

Conversation

alestiago
Copy link
Contributor

@alestiago alestiago commented Jul 9, 2024 •
edited
Loading

Description

Related to VeryGoodOpenSource/very_good_cli#1035

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago added the product: very_good_core Changes that affect the Very Good Core template. label Jul 9, 2024
@alestiago alestiago self-assigned this Jul 9, 2024
@alestiago alestiago marked this pull request as ready for review July 11, 2024 10:15
@alestiago alestiago requested a review from a team as a code owner July 11, 2024 10:15
@alestiago
Copy link
Contributor Author

Tried it on Android and iOs and it seems to be working as expected.

@alestiago alestiago added this pull request to the merge queue Jul 23, 2024
Merged via the queue into main with commit 9ea133a Jul 23, 2024
6 checks passed
@alestiago alestiago deleted the alestiago/pre_gen branch July 23, 2024 14:52
@alestiago alestiago mentioned this pull request Jul 24, 2024
Closed
This was referenced Jul 25, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomarra tomarra tomarra approved these changes

Assignees

@alestiago alestiago

Labels
product: very_good_core Changes that affect the Very Good Core template.
Projects
VGV Open Source 🦄 🧙🌟
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alestiago @tomarra