ServerBuilder does not correctly use 'wss' when used over https

[mofojed]

There appears to be a bug in ServerBuilder:

gwt-rpc/endpoint-client-gwt/src/main/java/org/gwtproject/rpc/gwt/client/impl/ServerBuilderImpl.java

Line 35 in 4f30df7

urlBuilder.protocol = DomGlobal.self.location.protocol.equals("https") ? "wss": "ws";

Here it's checking if window.location.protocol == 'https'. However, the protocol property includes the colon, and returns 'https:'. This check is always false and so always reverts to ws for the protocol set.

See MDN page about location.protocol: https://developer.mozilla.org/en-US/docs/Web/API/Location/protocol

The protocol property of the Location interface is a string representing the protocol scheme of the URL, including the final ':'.

[niloc132]

Thanks - I think this is best resolved by removing the default url entirely, so that ServerBuilder is compatible with non-browser JS environments?