Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a memory region does not delete/hide analysis artifacts (datavars, functions, etc.) in that region #5925

Open
negasora opened this issue Sep 12, 2024 · 2 comments
Labels
Component: Core Issue needs changes to the core Effort: Medium Issue should take < 1 month Impact: Low Issue is a papercut or has a good, supported workaround

Comments

@negasora
Copy link
Member

negasora commented Sep 12, 2024

Repro steps:

  1. Open a.txt
  2. Add a memory region: bv.memory_map.add_memory_region("a", 0xdeadbeef, b'A'*0x8)
  3. Rename the variable a in main
  4. Notice bv.data_vars now includes 3735928559: <var 0xdeadbeef: void>
  5. Remove the memory region: bv.memory_map.remove_memory_region("a")
  6. Notice that bv.data_vars still includes 3735928559: <var 0xdeadbeef: void>
@negasora negasora added Component: Core Issue needs changes to the core State: Awaiting Triage Issue is waiting for more in-depth triage from a developer labels Sep 12, 2024
@xusheng6
Copy link
Member

I think this is also true with functions, or any other analysis artifacts related to the newly added memory region

@negasora negasora changed the title Removing a memory region does not delete/hide data vars in that region Removing a memory region does not delete/hide analysis artifacts (datavars, functions, etc.) in that region Sep 16, 2024
@plafosse
Copy link
Member

I can see the desire for this in the UI but having the remove_memory_region API do that seems a little heavy handed as you should just be able to remove the data vars and functions in that region with the API easily as well.

@plafosse plafosse added Impact: Low Issue is a papercut or has a good, supported workaround Effort: Medium Issue should take < 1 month Component: UI Issue needs changes to the user interface and removed State: Awaiting Triage Issue is waiting for more in-depth triage from a developer Component: UI Issue needs changes to the user interface labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Issue needs changes to the core Effort: Medium Issue should take < 1 month Impact: Low Issue is a papercut or has a good, supported workaround
Projects
None yet
Development

No branches or pull requests

3 participants