Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to remove the user lock file to release updates #363

Open
mirkobrombin opened this issue Sep 6, 2024 · 3 comments
Open

Add ability to remove the user lock file to release updates #363

mirkobrombin opened this issue Sep 6, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@mirkobrombin
Copy link
Member

Currently, if the user interrupt an upgrade from the vso-gnome-ext, it is not possible to remove it if not manually from /tmp. We need a command to simplify the process, for example abroot remove-user-lock or abroot unlock-updates in we also want to remove the internal upgrade lock file, in case it was kept, in this last case we should also check if an abroot process is running, to avoid breaking updates.

@mirkobrombin mirkobrombin added the enhancement New feature or request label Sep 6, 2024
@axtloss
Copy link
Member

axtloss commented Sep 6, 2024

I dont think users should be able to remove lockfiles
We instead should be putting more effort into ensuring that the lockfile gets properly removed by abroot when the user cancels an upgrade

@mirkobrombin
Copy link
Member Author

mirkobrombin commented Sep 6, 2024

I was thinking about it, but I think the "user" lock should stay for the entire session. I mean, updates are done at intervals while the smaller one is "daily", so it might only be an issue for those who don't turn off their device in 1 day.

@taukakao
Copy link
Member

taukakao commented Nov 8, 2024

I think we should have both a file that locks abroot during an upgrade and a file that locks it after an upgrade completed successfully.

So if an upgrade fails, then the first lock file will be removed but the second lock file will not be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants