Add useful display handling features #1105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a mixmatch with the protocol declarations
ShadowApex
reviewed
Jan 19, 2024
| @@ -98,5 +98,22 @@ | |||
| <arg name="path" type="string" summary="Path to written screenshot"></arg> | |||
| </event> | |||
|
|
|||
| <enum name="display_rotation_flag" bitfield="true" since="2"> | |||
There was a problem hiding this comment.
Do we need to set this to version 4? (since="4")
There was a problem hiding this comment.
Yes, but it doesn't really matter for enums.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did my best to test all cases scenarios and all seems to check out. With the changes in this branch you can do the following.
--force-external-orientation--force-panel-type(This is useful for debugging as well as exposing options such as scaling in Steam)