Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in focus editor group commands (#81) #82

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

CAESIUS-TIM
Copy link
Contributor

@CAESIUS-TIM CAESIUS-TIM commented Dec 28, 2023

fix #81

@MarcoIeni
Copy link
Member

I would remove the word "group" because we call them just "editor" I think.

Also, what's the difference between previous and left in this context?

@CAESIUS-TIM
Copy link
Contributor Author

CAESIUS-TIM commented Dec 30, 2023

previous also focuses left but in a cycle, meaning it will focus the rightmost window when you're on the leftmost.

It's just too powerful and different from vim shortcut.

If there is no need to change previous and next, I still recommend to change "move" into "focus" because it's confused with "move editor to another group", like workbench.action.moveEditorToLeftGroup.

editor group commands

@MarcoIeni
Copy link
Member

meaning it will focus the rightmost window when you're on the leftmost

This seems like a "feature" to me 😅 but let's wait on @stevenguh to see if he has any preference. 👍

@stevenguh
Copy link
Member

These makes sense to me in a first glance. which-key uses the the vscode naming

Copy link
Member

@MarcoIeni MarcoIeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, merging than, thanks!

@MarcoIeni MarcoIeni merged commit f304f4f into VSpaceCode:master Jan 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typos in commands
3 participants