Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoUpdate fails to correctly detect how my vscodium was installed #2042

Open
Zalnd opened this issue Sep 29, 2024 · 6 comments
Open

AutoUpdate fails to correctly detect how my vscodium was installed #2042

Zalnd opened this issue Sep 29, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@Zalnd
Copy link

Zalnd commented Sep 29, 2024

Following this answer to another issue, I think autoupdate is failing to correctly detect how my vscodium was installed: even though the version I have installed isn't the portable one, autoupdate is directing me to the ZIP download link.

It send you to the url because it can't detect how it was installed and so which installer to download and execute.

The update process doesn't support the Portable Mode, same as Visual Studio Code (cf note in https://code.visualstudio.com/docs/editor/portable).

Originally posted by @daiyam in #1994 (comment)

@Zalnd Zalnd added the bug Something isn't working label Sep 29, 2024
@daiyam
Copy link
Member

daiyam commented Sep 29, 2024

How was it?

Bug report requires at least:

Desktop (please complete the following information):

  • OS: [e.g. Mac OS, Ubuntu 20.04, etc]
  • Architecture: [e.g. x64, ia32, arm64]
  • Version: [e.g. 1.33.0]
  • App Manager: [e.g. Winget, Homebrew, Snap, AUR, RPM, Nix, ...]
  • Sandboxed: [e.g. no, Flatpak, Snap]

@Zalnd
Copy link
Author

Zalnd commented Sep 30, 2024

How was it?

Bug report requires at least:

Desktop (please complete the following information):

  • OS: [e.g. Mac OS, Ubuntu 20.04, etc]
  • Architecture: [e.g. x64, ia32, arm64]
  • Version: [e.g. 1.33.0]
  • App Manager: [e.g. Winget, Homebrew, Snap, AUR, RPM, Nix, ...]
  • Sandboxed: [e.g. no, Flatpak, Snap]

Sorry, I deleted the template and forgot to come back to it.

Desktop:

OS: Windows 11 Home 23H2 22631.4169
Architecture: x64
Version: VSCodium 1.92.2 24228
App Manager: None (installed for all users via VSCodium-x64-1.92.2.24228.msi)

@Zalnd Zalnd closed this as completed Sep 30, 2024
@Zalnd Zalnd reopened this Sep 30, 2024
@daiyam
Copy link
Member

daiyam commented Sep 30, 2024

Can you give the path of the VSCodium.exe?

@Zalnd
Copy link
Author

Zalnd commented Sep 30, 2024

Sure.

C:\VSCodium\VSCodium.exe

@daiyam
Copy link
Member

daiyam commented Sep 30, 2024

.msi are expected to be installed in Program Files...

Here the patch: https://github.com/VSCodium/vscodium/blob/master/patches/windows/update.patch

@Zalnd
Copy link
Author

Zalnd commented Sep 30, 2024

.msi are expected to be installed in Program Files...

Here the patch: https://github.com/VSCodium/vscodium/blob/master/patches/windows/update.patch

Well, in that case, this option should either be blocked or a warning should be given that auto-update will effectively be disabled. What do you think?

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants