Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in prediction code? #5

Open
danielegrattarola opened this issue Nov 17, 2020 · 1 comment
Open

Bug in prediction code? #5

danielegrattarola opened this issue Nov 17, 2020 · 1 comment

Comments

@danielegrattarola
Copy link

Hello,

I am looking at the VGRNN_prediction.py script and I found what seems to be a bug on this line:

nll_loss += self._nll_bernoulli(dec_t_sl, adj_orig_dense_list[t])

Shouldn't it be:

nll_loss += self._nll_bernoulli(dec_t_sl, adj_orig_dense_list[t + 1])

in order to do link prediction for the graph at time T+1?
Did I misunderstand something?

Thanks

@Frankie123421
Copy link

I think it's actually the log-likelihood term of the loss function (equation 7), which means reconstructing A[t] by Z[t] at each time step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants