Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified reader icons #212

Open
wants to merge 16 commits into
base: upsilon-dev
Choose a base branch
from

Conversation

Overengined
Copy link

I modified the reader Icons to add a little bookmark to them.
I also modified a bit the center of the books to make it look less "weird".
I think it looks nicer.

@github-actions
Copy link

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 815456 bytes 440690 bytes 226552 bytes 1776 bytes 228328 bytes 1257922 bytes
Head 815456 bytes 440786 bytes 226552 bytes 1776 bytes 228328 bytes 1258018 bytes
+0 bytes +96 bytes +0 bytes +0 bytes +0 bytes +96 bytes
+0.0 % +0.0 % +0.0 % +0.0 % +0.0 % +0.0 %

@Lauryy06
Copy link
Member

I'm not really excited about this change, the bookmarks are weird.

@Overengined
Copy link
Author

Overengined commented Apr 24, 2022

OK :/
Well, I can remove them and jut keep the changes I made to the center of the books.
Would that be good ?

@Lauryy06
Copy link
Member

Like this ?
image
Sorry but I also find it weird...

@Overengined
Copy link
Author

Well, obviously not exactly like this because now that the bookmarks are gone, I shall adjust the colors.

@Lauryy06
Copy link
Member

You can try to see

removed bookmarks
@github-actions
Copy link

github-actions bot commented May 7, 2022

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 815456 bytes 440690 bytes 226552 bytes 1776 bytes 228328 bytes 1257922 bytes
Head 815456 bytes 440706 bytes 226552 bytes 1776 bytes 228328 bytes 1257938 bytes
+0 bytes +16 bytes +0 bytes +0 bytes +0 bytes +16 bytes
+0.0 % +0.0 % +0.0 % +0.0 % +0.0 % +0.0 %

@Lauryy06
Copy link
Member

I'll be honest, I prefer the current icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants