Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: store QSettings in a single location #129

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

slipher
Copy link
Contributor

@slipher slipher commented Jul 13, 2024

Fixes the Linux part of #121. Choose the location of our settings by changing the default location for settings, rather than customizing the parameter of our settings object. This makes it so the settings added by a component we depend on end up in the same place.

Copy link
Member

@illwieckz illwieckz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@illwieckz illwieckz dismissed a stale review July 14, 2024 02:04

Duplicate

@DolceTriade
Copy link
Member

Can you note why Windows is different than the unixes?

@slipher
Copy link
Contributor Author

slipher commented Jul 14, 2024

Can you note why Windows is different than the unixes?

Done.

@DolceTriade
Copy link
Member

I still don't understand the reasoning? Is it that the name "Unvanquished Development" is better on Windows?

@slipher
Copy link
Contributor Author

slipher commented Jul 14, 2024

I still don't understand the reasoning? Is it that the name "Unvanquished Development" is better on Windows?

With the organization name, actually Mac and Windows are the same and Linux will now be different. Previously, we chose the unvanquished/updater path to store the main settings of the updater. Some stuff was stored in an Unvanquished Development/Unvanquished Updater path by accident; I want to stop that. We need to go with the lowercase one to maintain compatibility with the previous version of the updater. But yes, the lowercase ones seem more in line with Linux stylistic conventions.

@DolceTriade
Copy link
Member

Please comment this rationale in the code and/or the commit message.

LGTM.

Fixes the Linux part of Unvanquished#121. Choose the location of our settings by
changing the default location for settings, rather than customizing the
parameter of our settings object. This makes it so the settings added by
a component we depend on end up in the same place.

Some more explanation quoted from the Github thread:

>   I still don't understand the reasoning? Is it that the name
    "Unvanquished Development" is better on Windows?

>   With the organization name, actually Mac and Windows are the same
    and Linux will now be different. Previously, we chose the
    unvanquished/updater path to store the main settings of the updater.
    Some stuff was stored in an Unvanquished Development/Unvanquished
    Updater path by accident; I want to stop that. We need to go with
    the lowercase one to maintain compatibility with the previous
    version of the updater. But yes, the lowercase ones seem more in
    line with Linux stylistic conventions.
@slipher slipher merged commit 40ad807 into Unvanquished:master Jul 16, 2024
2 checks passed
@slipher slipher deleted the settings-path branch July 16, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants